fix error with trailing slash at the end #749
Conversation
|
It looks like @IvanProdaiko94 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
|
[clabot:check] |
|
@confluentinc It looks like @IvanProdaiko94 just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
🤦♂ , good catch. Why not pop the url from the dict up here though Also please add a unit test that validates the trailing "/" is stripped from the url to avoid future regressions. |
|
@rnpridgeon so, I did what you asked about) |
To whom it may concern:
if you define the url for schema registry with
/in the end, the lib will construct the wrong one.Example:
schema_registy_host=http://localhost:1234/will lead to
http://localhost:1234//schemas/whatever_nextThe lib does strip the
/at the end of the string herebut several lines below get the deleted url from config with '/'.
So, with this fix there will be no error if the path of the schema registry will be defined like so:
http://localhost:1234/